2019-09-17, 13:26:49 +0200, Steffen Klassert wrote: > On Wed, Sep 11, 2019 at 04:13:07PM +0200, Sabrina Dubroca wrote: > ... > > diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig > > index 51bb6018f3bf..e67044527fb7 100644 > > --- a/net/xfrm/Kconfig > > +++ b/net/xfrm/Kconfig > > @@ -73,6 +73,16 @@ config XFRM_IPCOMP > > select CRYPTO > > select CRYPTO_DEFLATE > > > > +config XFRM_ESPINTCP > > + bool "ESP in TCP encapsulation (RFC 8229)" > > + depends on XFRM && INET_ESP > > + select STREAM_PARSER > > + select NET_SOCK_MSG > > + help > > + Support for RFC 8229 encapsulation of ESP and IKE over TCP sockets. > > + > > + If unsure, say N. > > + > > One nitpick: This is IPv4 only, so please move this below the ESP > section in net/ipv4/Kconfig and use the naming convention there. > I.e. bool "IP: ESP in TCP encapsulation (RFC 8229)"
That's temporary, though, the next step will be to make it work for both IPv4 and IPv6. Do you prefer I move it to net/ipv4/Kconfig for now, and then back to net/xfrm/Kconfig when I add IPv6 support? > Everything else looks very good! Thanks! -- Sabrina
