Sun, Sep 15, 2019 at 10:06:02AM CEST, ido...@idosch.org wrote: >On Sat, Sep 14, 2019 at 08:45:55AM +0200, Jiri Pirko wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> Currently all users of FIB notifier only cares about events in init_net. > >s/cares/care/
ok > >> Later in this patchset, users get interested in other namespaces too. >> However, for every registered block user is interested only about one >> namespace. Make the FIB notifier registration per-netns and avoid >> unnecessary calls of notifier block for other namespaces. > >... > >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c >> b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c >> index 5d20d615663e..fe0cc969cf94 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c >> @@ -248,9 +248,6 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, >> struct net_device *fib_dev; >> struct fib_info *fi; >> >> - if (!net_eq(info->net, &init_net)) >> - return NOTIFY_DONE; > >I don't see anymore uses of 'info->net'. Can it be removed from 'struct >fib_notifier_info' ? correct. I missed that.
