Thu, Sep 12, 2019 at 07:22:30PM CEST, xiyou.wangc...@gmail.com wrote: >When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL >pointer which leads to a crash in sfb_destroy(). Similar for >sch_dsmark. > >Instead of fixing each separately, Linus suggested to just accept >NULL pointer in qdisc_put(), which would make callers easier. > >(For sch_dsmark, the bug probably exists long before commit >6529eaba33f0.) > >Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure") >Reported-by: syzbot+d5870a903591faaca...@syzkaller.appspotmail.com >Suggested-by: Linus Torvalds <torva...@linux-foundation.org> >Cc: Jamal Hadi Salim <j...@mojatatu.com> >Cc: Jiri Pirko <j...@resnulli.us> >Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Jiri Pirko <j...@mellanox.com> Thanks!