Thu, Sep 12, 2019 at 07:22:30PM CEST, [email protected] wrote: >When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL >pointer which leads to a crash in sfb_destroy(). Similar for >sch_dsmark. > >Instead of fixing each separately, Linus suggested to just accept >NULL pointer in qdisc_put(), which would make callers easier. > >(For sch_dsmark, the bug probably exists long before commit >6529eaba33f0.) > >Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure") >Reported-by: [email protected] >Suggested-by: Linus Torvalds <[email protected]> >Cc: Jamal Hadi Salim <[email protected]> >Cc: Jiri Pirko <[email protected]> >Signed-off-by: Cong Wang <[email protected]>
Acked-by: Jiri Pirko <[email protected]> Thanks!
