> -----Original Message----- > From: Mauro S. M. Rodrigues [mailto:maur...@linux.vnet.ibm.com] > Sent: Tuesday, September 3, 2019 12:20 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; > da...@davemloft.net; Bowers, AndrewX <andrewx.bow...@intel.com>; > Jakub Kicinski <jakub.kicin...@netronome.com>; > maur...@linux.vnet.ibm.com > Subject: [PATCH v2 net-next 2/2] i40e: Implement debug macro hw_dbg > using dev_dbg > > There are several uses of hw_dbg in the code, producing no output. This > patch implments it using dev_debug. > > Initially the intention was to implement it using netdev_dbg, analogously to > what is done in ixgbe for instance. That approach was avoided due to some > early usages of hw_dbg, like i40e_pf_reset, before the vsi structure > initialization causing NULL pointer dereference during the driver probe if the > dbg messages were turned on as soon as the module is probed. > > v2: > - Use dev_dbg instead of pr_debug, and take advantage of dev_name > instead of crafting pretty much the same device name locally as suggested by > Jakub Kicinski. > > Signed-off-by: Mauro S. M. Rodrigues <maur...@linux.vnet.ibm.com> > --- > drivers/net/ethernet/intel/i40e/i40e_common.c | 1 + > drivers/net/ethernet/intel/i40e/i40e_hmc.c | 1 + > drivers/net/ethernet/intel/i40e/i40e_osdep.h | 5 ++++- > 3 files changed, 6 insertions(+), 1 deletion(-)
Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
