From: Vinicius Costa Gomes <vinicius.go...@intel.com> Date: Wed, 28 Aug 2019 10:36:15 -0700
> When removing a cbs instance when offloading is enabled, the crash > below can be observed. Also, the current code doesn't handle correctly > the case when offload is disabled without removing the qdisc: if the > link speed changes the credit calculations will be wrong. I think it does handle that case correctly, because in the !offloaded code path of cbs_change() it makes an explict call to the function cbs_set_port_rate(). And that is the only location where offload can be disabled on an already existing instance. If you agree, please fix your commit message to be more accurate on this point. Thank you.
