On Thu, 29 Aug 2019 11:56:42 +0100, Quentin Monnet wrote: > Hi, > This set attempts to make it easier to build bpftool, in particular when > passing a specific output directory. This is a follow-up to the > conversation held last month by Lorenz, Ilya and Jakub [0]. > > The first patch is a minor fix to bpftool's Makefile, regarding the > retrieval of kernel version (which currently prints a non-relevant make > warning on some invocations). > > Second patch improves the Makefile commands to support more "make" > invocations, or to fix building with custom output directory. On Jakub's > suggestion, a script is also added to BPF selftests in order to keep track > of the supported build variants. > > At last, third patch is a sligthly modified version of Ilya's fix regarding > libbpf.a appearing twice on the linking command for bpftool. > > [0] > https://lore.kernel.org/bpf/CACAyw9-CWRHVH3TJ=Tke2x8YiLsH47sLCijdp=v+5m836r9...@mail.gmail.com/
I think Ilya has a point, but otherwise looks good to me :) Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com>
