From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 07 Feb 2007 00:03:25 +0100
> I believe dead code from sock_from_file() can be cleaned up. > > All sockets are now built using sock_attach_fd(), that puts the 'sock' > pointer > into file->private_data and &socket_file_ops into file->f_op > > I could not find a place where file->private_data could be set to NULL, > keeping opened the file. > > So to get 'sock' from a 'file' pointer, either : > > - This is a socket file (f_op == &socket_file_ops), and we can directly get > 'sock' from private_data. > - This is not a socket, we return -ENOTSOCK and dont even try to find a > socket > via dentry/inode :) > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Looks good to me, applied, thanks Eric. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html