From: Michael Chan <michael.c...@broadcom.com> Date: Sun, 25 Aug 2019 23:54:52 -0400
> If the silent parameter is set, suppress all messages when there is > no response from firmware. When polling for firmware to come out of > reset, no response may be normal and we want to suppress the error > messages. Also, don't poll for the firmware DMA response if Bus Master > is disabled. This is in preparation for error recovery when firmware > may be in error or reset state or Bus Master is disabled. > > Signed-off-by: Michael Chan <michael.c...@broadcom.com> The function bnxt_hwrm_do_send_msg() seems to be an interesting mix of return values, what are the semantics? It seems to use 0 for success, some error codes, and -1. Does -1 have special meaning? Just curious, and really this unorthodox return value semantic should be documented into a comment above the function.
