On Sun, 25 Aug 2019 05:59:12 +0200, Marek Behún <marek.be...@nic.cz> wrote:
> int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
> {
> - int lane;
> -
> - lane = mv88e6390_serdes_get_lane(chip, port);
> - if (lane == -ENODEV)
> - return 0;
> + s8 lane;
> + int err;
>
> + err = mv88e6xxx_serdes_get_lane(chip, port, &lane);
> + if (err)
> + return err;
> if (lane < 0)
> - return lane;
> + return 0;
In fact you're also relying on -ENODEV, which is what you return here (and in
other places) instead of 0. So I'm afraid you have to address my comment now...
