On Fri, 23 Aug 2019 16:37:43 -0700, Jeff Kirsher wrote: > From: Dave Ertman <[email protected]> > > The current flag name of "enable-fw-lldp" is a bit cumbersome. > > Change priv-flag name to "fw-lldp-agent" with a value of on or > off. This is more straight-forward in meaning. > > Signed-off-by: Dave Ertman <[email protected]> > Tested-by: Andrew Bowers <[email protected]> > Signed-off-by: Jeff Kirsher <[email protected]>
Just flagging this for Dave, it was introduced in v5.2 by: commit 3a257a1404f8bf751a258ab92262dcb2cce39eef Author: Anirudh Venkataramanan <[email protected]> Date: Thu Feb 28 15:24:31 2019 -0800 ice: Add code to control FW LLDP and DCBX This patch adds code to start or stop LLDP and DCBX in firmware through use of ethtool private flags. Signed-off-by: Anirudh Venkataramanan <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]> And changed once already in v5.3-rc by: commit 31eafa403b9945997cf5b321ae3560f072b74efe Author: Anirudh Venkataramanan <[email protected]> Date: Tue Apr 16 10:24:25 2019 -0700 ice: Implement LLDP persistence Implement LLDP persistence across reboots, start and stop of LLDP agent. Add additional parameter to ice_aq_start_lldp and ice_aq_stop_lldp. Also change the ethtool private flag from "disable-fw-lldp" to "enable-fw-lldp". This change will flip the boolean logic of the functionality of the flag (on = enable, off = disable). The change in name and functionality is to differentiate between the pre-persistence and post-persistence states. Signed-off-by: Anirudh Venkataramanan <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]> Perhaps the rename should target net? IDK how much driver flag renaming is okay otherwise, I guess this will only affect Intel users.
