On Tue, Aug 20, 2019 at 04:57:28PM -0700, David Miller wrote: > > From: "Matthew Wilcox (Oracle)" <wi...@infradead.org> > > > > This module doesn't use the allocating functionality; convert it to a > > plain XArray instead of an allocating one. I've left struct tcf_net > > in place in case more objects are added to it in future, although > > it now only contains an XArray. We don't need to call xa_destroy() > > if the array is empty, so I've removed the contents of tcf_net_exit() > > -- if it can be called with entries still in place, then it shoud call > > xa_destroy() instead. > > > > Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org> > > I don't know if the net exit can be invoked with entires still in place, > however if the tcf_net_exit() function is made empty it should be removed > along with the assignment to the per-netns ops.
Thanks! I wasn't sure what the rule was for these ops. I'll fix that up.