On 8/19/19 5:00 PM, Vladimir Oltean wrote: > The bridge core assumes that enabling/disabling vlan_filtering will > translate into the simple toggling of a flag for switchdev drivers. > > That is clearly not the case for sja1105, which alters the VLAN table > and the pvids in order to obtain port separation in standalone mode. > > So, since the bridge will not call any vlan operation through switchdev > after enabling vlan_filtering, we need to ensure we're in a functional > state ourselves. > > Hence read the pvid that the bridge is aware of, and program that into > our ports. > > Signed-off-by: Vladimir Oltean <olte...@gmail.com>
OK, after reading how drivers/net/dsa/sja1105/sja1105_main.c::sja1105_vlan_filtering makes use of that functionality, that looks like the correct thing to do. Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian
