On Fri, 16 Aug 2019 12:25:52 -0400 Vivien Didelot <vivien.dide...@gmail.com> wrote:
> So now we have mv88e6xxx_setup_port() and mv88e6xxx_port_setup(), which both > setup a port, differently, at different time. This is definitely error prone. Hmm. I don't know how much of mv88e6xxx_setup_port() could be moved to this new port_setup(), since there are other setup functions called in mv88e6xxx_setup() that can possibly depend on what was done by mv88e6xxx_setup_port(). Maybe the new DSA operations should be called .after_setup() and .before_teardown(), and be called just once for the whole switch, not for each port?
