On Wed, Aug 14, 2019 at 3:16 PM Andrey Ignatov <r...@fb.com> wrote: > > Andrii Nakryiko <andr...@fb.com> [Wed, 2019-08-14 13:57 -0700]: > > Currently libbpf version is specified in 2 places: libbpf.map and > > Makefile. They easily get out of sync and it's very easy to update one, > > but forget to update another one. In addition, Github projection of > > libbpf has to maintain its own version which has to be remembered to be > > kept in sync manually, which is very error-prone approach. > > > > This patch makes libbpf.map a source of truth for libbpf version and > > uses shell invocation to parse out correct full and major libbpf version > > to use during build. Now we need to make sure that once new release > > cycle starts, we need to add (initially) empty section to libbpf.map > > with correct latest version. > > > > This also will make it possible to keep Github projection consistent > > with kernel sources version of libbpf by adopting similar parsing of > > version from libbpf.map. > > > > v2->v3: > > - grep -o + sort -rV (Andrey); > > > > v1->v2: > > - eager version vars evaluation (Jakub); > > - simplified version regex (Andrey); > > Acked-by: Andrey Ignatov <r...@fb.com>
Applied. Thanks
