On Wed, Aug 14, 2019 at 05:42:29PM -0700, Jakub Kicinski wrote: > On Tue, 13 Aug 2019 10:53:59 +0300, Ido Schimmel wrote: > > From: Ido Schimmel <ido...@mellanox.com> > > > > Add test cases for devlink-trap on top of the netdevsim implementation. > > > > The tests focus on the devlink-trap core infrastructure and user space > > API. They test both good and bad flows and also dismantle of the netdev > > and devlink device used to report trapped packets. > > > > This allows device drivers to focus their tests on device-specific > > functionality. > > > > Signed-off-by: Ido Schimmel <ido...@mellanox.com> > > Acked-by: Jiri Pirko <j...@mellanox.com> > > Thanks for the test! > > Should it perhaps live in: > tools/testing/selftests/drivers/net/netdevsim/ > ? > > That's where Jiri puts his devlink tests..
Yea, good point. Will move it there. > > Also the test seems to require netdevsim to be loaded, otherwise: > # ./devlink_trap.sh > SKIP: No netdevsim support > > Is that expected? No, my bad. I need to change the check to see if netdevsim is loaded and otherwise load the module. Thanks!
