On Mon, Aug 12, 2019 at 08:49:12PM +0800, Xin Long wrote:
> As the annotation says in sctp_do_8_2_transport_strike():
>
> "If the transport error count is greater than the pf_retrans
> threshold, and less than pathmaxrtx ..."
>
> It should be transport->error_count checked with pathmaxrxt,
> instead of asoc->pf_retrans.
>
> Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg")
> Signed-off-by: Xin Long <[email protected]>
Acked-by: Marcelo Ricardo Leitner <[email protected]>
Dave, please consider this one for stable. Thanks.
> ---
> net/sctp/sm_sideeffect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index a554d6d..1cf5bb5 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -546,7 +546,7 @@ static void sctp_do_8_2_transport_strike(struct
> sctp_cmd_seq *commands,
> */
> if (net->sctp.pf_enable &&
> (transport->state == SCTP_ACTIVE) &&
> - (asoc->pf_retrans < transport->pathmaxrxt) &&
> + (transport->error_count < transport->pathmaxrxt) &&
> (transport->error_count > asoc->pf_retrans)) {
>
> sctp_assoc_control_transport(asoc, transport,
> --
> 2.1.0
>
