On 12.08.2019 23:27, Andrew Lunn wrote: > On Mon, Aug 12, 2019 at 11:19:31PM +0200, Heiner Kallweit wrote: >> We will need the functionality of __set_linkmode_max_speed also for >> linkmode bitmaps other than phydev->supported. Therefore split it. >> >> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> >> --- >> drivers/net/phy/phy-core.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c >> index 9ae3abb2d..de085f255 100644 >> --- a/drivers/net/phy/phy-core.c >> +++ b/drivers/net/phy/phy-core.c >> @@ -207,14 +207,15 @@ size_t phy_speeds(unsigned int *speeds, size_t size, >> return count; >> } >> >> -static int __set_phy_supported(struct phy_device *phydev, u32 max_speed) >> +static int __set_linkmode_max_speed(struct phy_device *phydev, u32 >> max_speed, >> + unsigned long *addr) >> { > > Hi Heiner > > It looks like phydev is an unused parameter. Maybe it should be > removed? > Right, it can be removed. Thanks!
> Andrew > Heiner