On Mon, Aug 12, 2019 at 10:55:51AM -0700, Nick Desaulniers wrote: > On Sat, Aug 10, 2019 at 3:17 AM Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > Maybe adding this recommendation to the comment block above the > definition of debugfs_create_dir() in fs/debugfs/inode.c would help > prevent this issue in the future? What failure means, and how to > proceed can be tricky; more documentation can only help in this > regard.
If it was there, would you have read it? :) I'll add it to the list for when I revamp the debugfs documentation that is already in the kernel, that very few people actually read... thanks, greg k-h
