Hello!
On 11.08.2019 18:08, Marek Behún wrote:
The mv88e6xxx_port_setup_mac looks if one of the {link, speed, duplex}
parameters is being changed from the current setting, and if not, does
not do anything. This test is wrong in some situations: this method also
has the mode argument, which can also be changed.
For example on Turris Omnia, the mode is PHY_INTERFACE_MODE_RGMII_ID,
which has to be set byt the ->port_set_rgmii_delay method. The test does
s/byt/by/?
not look if mode is being changed (in fact there is currently no method
to determine port mode as phy_interface_t type).
The simplest solution seems to be to drop this test altogether and
simply do the setup when requested.
Signed-off-by: Marek Behún <[email protected]>
Cc: Heiner Kallweit <[email protected]>
Cc: Sebastian Reichel <[email protected]>
Cc: Vivien Didelot <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: David S. Miller <[email protected]>
[...]
MBR, Sergei
