Re: [PATCH 5/7] sky2: Yukon Extreme support

[Francois Romieu]

Stephen Hemminger <[EMAIL PROTECTED]> :
[...]
> @@ -289,8 +289,10 @@
>       struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
>       u16 ctrl, ct1000, adv, pg, ledctrl, ledover, reg;
>  
> -     if (sky2->autoneg == AUTONEG_ENABLE &&
> -         !(hw->chip_id == CHIP_ID_YUKON_XL || hw->chip_id == 
> CHIP_ID_YUKON_EC_U)) {
> +     if (sky2->autoneg == AUTONEG_ENABLE
> +         && !(hw->chip_id == CHIP_ID_YUKON_XL
> +              || hw->chip_id == CHIP_ID_YUKON_EC_U
> +              || hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +                     if (sky2->autoneg == AUTONEG_ENABLE
> +                         && (hw->chip_id == CHIP_ID_YUKON_XL
> +                             || hw->chip_id == CHIP_ID_YUKON_EC_U
> +                             || hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +     if (hw->chip_id == CHIP_ID_YUKON_XL
> +         || hw->chip_id == CHIP_ID_YUKON_EC_U
> +         || hw->chip_id == CHIP_ID_YUKON_EX) {
[...]
> +     if (hw->chip_id == CHIP_ID_YUKON_XL
> +         || hw->chip_id == CHIP_ID_YUKON_EC_U
> +         || hw->chip_id == CHIP_ID_YUKON_EX)

Any objection against the use of :

static bool is_yukon_extreme(struct sky2_hw *hw)
{
        return hw->chip_id == CHIP_ID_YUKON_XL ||
                hw->chip_id == CHIP_ID_YUKON_EC_U ||
                hw->chip_id == CHIP_ID_YUKON_EX;
}

?

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html