On 11.08.2019 05:39, Andrew Lunn wrote:
> On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek Behún wrote:
>> Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in
>> genphy_read_status") broke fixed link DSA port registration in
>> dsa_port_fixed_link_register_of: the genphy_read_status does not do what
>> it is supposed to and the following adjust_link is given wrong
>> parameters.
>
> Hi Marek
>
> Which parameters are incorrect?
>
> In fixed_phy.c, __fixed_phy_register() there is:
>
> /* propagate the fixed link values to struct phy_device */
> phy->link = status->link;
> if (status->link) {
> phy->speed = status->speed;
> phy->duplex = status->duplex;
> phy->pause = status->pause;
> phy->asym_pause = status->asym_pause;
> }
>
> Are we not initialising something? Or is the initialisation done here
> getting reset sometime afterwards?
>
In addition to Andrew's question:
We talk about this DT config: armada-385-turris-omnia.dts ?
Which kernel version are you using?
> Thanks
> Andrew
>
Heiner
