On Mon, 05 Feb 2007 18:10:26 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: [EMAIL PROTECTED] > Date: Mon, 05 Feb 2007 16:31:11 -0800 > > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > "using smp_processor_id() in preemptible code" > > > > Cc: Patrick McHardy <[EMAIL PROTECTED]> > > Cc: "David S. Miller" <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > We NAK'd this because every patch in the lockdep trace should > have preemption disabled because software interrupts ought > to be disabled in those code paths. > > Someone needs to track down why this is really happening. I think the finger was pointed at preemptible rcu, in -mm. iirc, the net stats code is assuming that rcu_read_lock() disables preemption as a side-effect, which rcu-preempt makes no-longer-true. Not sure what to do there. Perhaps add a new rcu_read_lock_with_preempt_disable() thing which will dtrt with either config. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
