Thank you for letting me know. I will add to next version of patch. And, thank you for the detailed review. :)
On Fri, Aug 2, 2019 at 8:21 AM Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > > On Thu, 1 Aug 2019 17:11:31 +0900, Daniel T. Lee wrote: > > Currently, bpftool net only supports dumping progs attached on the > > interface. To attach XDP prog on interface, user must use other tool > > (eg. iproute2). By this patch, with `bpftool net attach/detach`, user > > can attach/detach XDP prog on interface. > > > > $ ./bpftool prog > > ... > > 208: xdp name xdp_prog1 tag ad822e38b629553f gpl > > loaded_at 2019-07-28T18:03:11+0900 uid 0 > > ... > > $ ./bpftool net attach id 208 xdpdrv enp6s0np1 > > $ ./bpftool net > > xdp: > > enp6s0np1(5) driver id 208 > > ... > > $ ./bpftool net detach xdpdrv enp6s0np1 > > $ ./bpftool net > > xdp: > > ... > > > > While this patch only contains support for XDP, through `net > > attach/detach`, bpftool can further support other prog attach types. > > > > XDP attach/detach tested on Mellanox ConnectX-4 and Netronome Agilio. > > Please provide documentation for man pages, and bash completions.
