Re: [PATCH 1/2] tools: bpftool: add net load command to load XDP on interface

[Jesper Dangaard Brouer]

On Wed, 31 Jul 2019 03:48:20 +0900
"Daniel T. Lee" <danieltim...@gmail.com> wrote:

> diff --git a/tools/bpf/bpftool/net.c b/tools/bpf/bpftool/net.c
> index 67e99c56bc88..d3a4f18b5b95 100644
> --- a/tools/bpf/bpftool/net.c
> +++ b/tools/bpf/bpftool/net.c
> @@ -55,6 +55,35 @@ struct bpf_attach_info {
>       __u32 flow_dissector_id;
>  };
>  
> +enum net_load_type {
> +     NET_LOAD_TYPE_XDP,
> +     NET_LOAD_TYPE_XDP_GENERIC,
> +     NET_LOAD_TYPE_XDP_DRIVE,

Why "DRIVE" ?
Why not "DRIVER" ?

> +     NET_LOAD_TYPE_XDP_OFFLOAD,
> +     __MAX_NET_LOAD_TYPE
> +};
> +
> +static const char * const load_type_strings[] = {
> +     [NET_LOAD_TYPE_XDP] = "xdp",
> +     [NET_LOAD_TYPE_XDP_GENERIC] = "xdpgeneric",
> +     [NET_LOAD_TYPE_XDP_DRIVE] = "xdpdrv",
> +     [NET_LOAD_TYPE_XDP_OFFLOAD] = "xdpoffload",
> +     [__MAX_NET_LOAD_TYPE] = NULL,
> +};



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer