Sun, Jul 07, 2019 at 01:53:02PM CEST, tar...@mellanox.com wrote: >From: Aya Levin <a...@mellanox.com> > >Add cq information to general diagnose output: CQ size and stride size. >Per SQ add information about the related CQ: cqn and CQ's HW status. > >$ devlink health diagnose pci/0000:00:0b.0 reporter tx >Common config: > SQ: stride size: 64 size: 1024 > CQ: stride size: 64 size: 1024 > SQs: > channel ix: 0 sqn: 4283 HW state: 1 stopped: false cc: 0 pc: 0 CQ: cqn: > 1030 HW status: 0
The nesting of "cqn" and "HW status" is not visible there. I know it is comment to iproute2 patch, but still. Should be corrected in this patch description too. Other than this, the patch looks good. > channel ix: 1 sqn: 4288 HW state: 1 stopped: false cc: 0 pc: 0 CQ: cqn: > 1034 HW status: 0 > channel ix: 2 sqn: 4293 HW state: 1 stopped: false cc: 0 pc: 0 CQ: cqn: > 1038 HW status: 0 > channel ix: 3 sqn: 4298 HW state: 1 stopped: false cc: 0 pc: 0 CQ: cqn: > 1042 HW status: 0 > >$ devlink health diagnose pci/0000:00:0b.0 reporter tx -jp >{ > "Common config": [ > "SQ": { > "stride size": 64, > "size": 1024 > }, > "CQ": { > "stride size": 64, > "size": 1024 > } ], > "SQs": [ { > "channel ix": 0, > "sqn": 4283, > "HW state": 1, > "stopped": false, > "cc": 0, > "pc": 0, > "CQ": { > "cqn": 1030, > "HW status": 0 > } > },{ > "channel ix": 1, > "sqn": 4288, > "HW state": 1, > "stopped": false, > "cc": 0, > "pc": 0, > "CQ": { > "cqn": 1034, > "HW status": 0 > } > },{ > "channel ix": 2, > "sqn": 4293, > "HW state": 1, > "stopped": false, > "cc": 0, > "pc": 0, > "CQ": { > "cqn": 1038, > "HW status": 0 > } > },{ > "channel ix": 3, > "sqn": 4298, > "HW state": 1, > "stopped": false, > "cc": 0, > "pc": 0, > "CQ": { > "cqn": 1042, > "HW status": 0 > } > } ] >} > >Signed-off-by: Aya Levin <a...@mellanox.com> >Signed-off-by: Tariq Toukan <tar...@mellanox.com> [...]