From: Andreas Steinmetz <a...@domdv.de> Date: Tue, 02 Jul 2019 22:49:54 +0200
> This patchset removes some unnecessary code in the receive path of the > macsec driver, and re-indents the error handling after calling > macsec_decrypt to make the post-processing clearer. > > This is a combined effort of Sabrina Dubroca <s...@queasysnail.net> and me. > > Change in 3/3: > > The patch now only moves the IS_ERR(skb) case under the block where > macsec_decrypt() is called, but not the call to macsec_post_decrypt(). > I really don't like these changes, especially patches #1 and #2. Like Willem I don't think you can blindly remove the share check like this (and you ignored his feedback about this from v1 it seems), and the removal is *pskb assignment to NULL is undoing defensive programming. I'm not applying this series.
