On 2019-06-29 01:15, Jonathan Lemon wrote: > + xdpf = convert_to_xdp_frame_keep_zc(xdp); > + if (unlikely(!xdpf)) > + return I40E_XDP_CONSUMED; > + xdpf->handle = xdp->handle;
Shouldn't this line belong to convert_to_xdp_frame_keep_zc (and the previous patch)? It looks like it's code common for all drivers, and also patch 1 adds the handle field, but doesn't use it, which looks weird.