From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 16:52:27 -0500
> David Miller wrote: > > Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763 > > > > It's wrong. We had a lengthy analysis of this piece of code > > several months ago, and it is correct. > > > > Consider, if we run the loop and we get an error > > the following happens: > > > > 1) attempt of ifb_init_one(i) fails, therefore we should > > not try to "ifb_free_one()" on "i" since it failed > > 2) the loop iteration first increments "i", then it > > check for error > > > > Therefore we must decrement "i" twice before the first > > free during the cleanup. One to "undo" the for() loop > > increment, and one to "skip" the ifb_init_one() case which > > failed. > > > > commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763 > > Author: Mariusz Kozlowski <[EMAIL PROTECTED]> > > Andrew and I both missed that thread, sorry. > > I'm about to crash, can you or Linus handle the correction? Sure. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
