Hi Stephen,
On Tue, Jun 25, 2019 at 11:58:06AM -0700, Stephen Hemminger wrote:
> On Tue, 25 Jun 2019 14:49:04 +0300
> Baruch Siach <bar...@tkos.co.il> wrote:
>
> > diff --git a/devlink/devlink.c b/devlink/devlink.c
> > index 436935f88bda..b400fab17578 100644
> > --- a/devlink/devlink.c
> > +++ b/devlink/devlink.c
> > @@ -1726,9 +1726,9 @@ static void pr_out_u64(struct dl *dl, const char
> > *name, uint64_t val)
> > jsonw_u64_field(dl->jw, name, val);
> > } else {
> > if (g_indent_newline)
> > - pr_out("%s %lu", name, val);
> > + pr_out("%s %llu", name, val);
> > else
> > - pr_out(" %s %lu", name, val);
> > + pr_out(" %s %llu", name, val);
>
> But on 64 bit target %llu expects unsigned long long which is 128bit.
Is that a problem?
> The better way to fix this is to use:
> #include <inttypes.h>
>
> And the use the macro PRIu64
> pr_out(" %s %"PRIu64, name, val);
I think it makes the code harder to read. But OK, I'll post an update to this
patch and the next.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
