Re: [PATCH bpf] tools: bpftool: use correct argument in cgroup errors

[Roman Gushchin]

On Tue, Jun 25, 2019 at 09:56:31AM -0700, Jakub Kicinski wrote:
> cgroup code tries to use argv[0] as the cgroup path,
> but if it fails uses argv[1] to report errors.
> 
> Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com>
> Reviewed-by: Quentin Monnet <quentin.mon...@netronome.com>

Acked-by: Roman Gushchin <g...@fb.com>

Thanks, Jakub!

> ---
>  tools/bpf/bpftool/cgroup.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c
> index 73ec8ea33fb4..a13fb7265d1a 100644
> --- a/tools/bpf/bpftool/cgroup.c
> +++ b/tools/bpf/bpftool/cgroup.c
> @@ -168,7 +168,7 @@ static int do_show(int argc, char **argv)
>  
>       cgroup_fd = open(argv[0], O_RDONLY);
>       if (cgroup_fd < 0) {
> -             p_err("can't open cgroup %s", argv[1]);
> +             p_err("can't open cgroup %s", argv[0]);
>               goto exit;
>       }
>  
> @@ -356,7 +356,7 @@ static int do_attach(int argc, char **argv)
>  
>       cgroup_fd = open(argv[0], O_RDONLY);
>       if (cgroup_fd < 0) {
> -             p_err("can't open cgroup %s", argv[1]);
> +             p_err("can't open cgroup %s", argv[0]);
>               goto exit;
>       }
>  
> @@ -414,7 +414,7 @@ static int do_detach(int argc, char **argv)
>  
>       cgroup_fd = open(argv[0], O_RDONLY);
>       if (cgroup_fd < 0) {
> -             p_err("can't open cgroup %s", argv[1]);
> +             p_err("can't open cgroup %s", argv[0]);
>               goto exit;
>       }
>  
> -- 
> 2.21.0
>