Re: [PATCH bpf-next v7 1/9] bpf: implement getsockopt and setsockopt hooks

[kbuild test robot]

Hi Stanislav,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-implement-getsockopt-and-setsockopt-hooks/20190621-064924
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm64-defconfig (attached as .config)
compiler: clang version 9.0.0 (git://gitmirror/llvm_project 
ca42687d62a81fb09fe0187e5f2788077eb6a841)
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   In file included from net/socket.c:109:
   In file included from include/net/busy_poll.h:30:
   In file included from include/net/ip.h:32:
   In file included from include/net/route.h:28:
   In file included from include/net/inetpeer.h:16:
   include/net/ipv6.h:378:8: warning: explicitly assigning value of variable of 
type 'struct ipv6_txoptions *' to itself [-Wself-assign]
      opt = (opt);
      ~~~ ^  ~~~
>> net/socket.c:2130:7: warning: explicitly assigning value of variable of type 
>> 'int' to itself [-Wself-assign]
     err = (err);
     ~~~ ^  ~~~
   2 warnings generated.

vim +/int +2130 net/socket.c

  2100  
  2101  /*
  2102   *      Get a socket option. Because we don't know the option lengths 
we have
  2103   *      to pass a user mode parameter for the protocols to sort out.
  2104   */
  2105  
  2106  static int __sys_getsockopt(int fd, int level, int optname,
  2107                              char __user *optval, int __user *optlen)
  2108  {
  2109          int err, fput_needed;
  2110          struct socket *sock;
  2111          int max_optlen;
  2112  
  2113          sock = sockfd_lookup_light(fd, &err, &fput_needed);
  2114          if (sock != NULL) {
  2115                  err = security_socket_getsockopt(sock, level, optname);
  2116                  if (err)
  2117                          goto out_put;
  2118  
  2119                  max_optlen = BPF_CGROUP_GETSOCKOPT_MAX_OPTLEN(optlen);
  2120  
  2121                  if (level == SOL_SOCKET)
  2122                          err =
  2123                              sock_getsockopt(sock, level, optname, 
optval,
  2124                                              optlen);
  2125                  else
  2126                          err =
  2127                              sock->ops->getsockopt(sock, level, optname, 
optval,
  2128                                                    optlen);
  2129  
> 2130                  err = BPF_CGROUP_RUN_PROG_GETSOCKOPT(sock->sk, level, 
> optname,
  2131                                                       optval, optlen,
  2132                                                       max_optlen, err);
  2133  out_put:
  2134                  fput_light(sock->file, fput_needed);
  2135          }
  2136          return err;
  2137  }
  2138  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

.config.gz
Description: application/gzip