On Thu, 20 Jun 2019 08:24:22 -0600
David Ahern <[email protected]> wrote:
> On 6/19/19 5:59 PM, Stefano Brivio wrote:
> > + if (filter->dump_exceptions) {
> > + struct fib6_nh_exception_dump_walker w = { .dump = arg,
> > + .rt = rt,
> > + .flags = flags,
> > + .skip = skip,
> > + .count = 0 };
> > + int err;
> > +
> > + if (rt->nh) {
> > + err = nexthop_for_each_fib6_nh(rt->nh,
> > + rt6_nh_dump_exceptions,
> > + &w);
>
> much like ipv4, the skb can fill in the middle of a fib6_nh bucket, so
> you need to track which nexthop is in progress.
Same as my comment about IPv4, except that, for IPv6, distinction
between skip and skip_in_node is strictly needed, but buckets and
nexthops are traversed in the same order and 'sernum' changes don't
affect that.
--
Stefano
