On Wed, Jun 19, 2019 at 4:21 PM David Ahern <dsah...@gmail.com> wrote:
>
> On 6/19/19 4:31 PM, Wei Wang wrote:
> > diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h
> > index e942372b077b..d8c37317bb86 100644
> > --- a/include/net/l3mdev.h
> > +++ b/include/net/l3mdev.h
> > @@ -31,8 +31,9 @@ struct l3mdev_ops {
> > u16 proto);
> >
> > /* IPv6 ops */
> > - struct dst_entry * (*l3mdev_link_scope_lookup)(const struct
> > net_device *dev,
> > - struct flowi6 *fl6);
> > + struct dst_entry * (*l3mdev_link_scope_lookup_noref)(
> > + const struct net_device *dev,
> > + struct flowi6 *fl6);
>
> I would prefer to add a comment about not taking a references vs adding
> the _noref extension. There is only 1 user for 1 context and the name
> length is getting out of hand (as evidenced by the line wrapping below).
Hmm OK. I was trying to make it clear to make sure future callers do
not misuse it.
