Thu, Jun 13, 2019 at 07:43:57PM CEST, [email protected] wrote:
>Currently, TC offers the ability to match on the MPLS fields of a packet
>through the use of the flow_dissector_key_mpls struct. However, as yet, TC
>actions do not allow the modification or manipulation of such fields.
>
>Add a new module that registers TC action ops to allow manipulation of
>MPLS. This includes the ability to push and pop headers as well as modify
>the contents of new or existing headers. A further action to decrement the
>TTL field of an MPLS header is also provided.
>
>Signed-off-by: John Hurley <[email protected]>
>Reviewed-by: Jakub Kicinski <[email protected]>
[...]
>+ if (tb[TCA_MPLS_LABEL] || tb[TCA_MPLS_TTL] || tb[TCA_MPLS_TC]) {
>+ NL_SET_ERR_MSG_MOD(extack,
>+ "MPLS POP: unsupported attrs");
No need to break line here and couple other similar places in this code.
Anyway, looks good otherwise:
Acked-by: Jiri Pirko <[email protected]>
[...]
