> /** > + * Advertised link speeds > + */ > +#define DPNI_ADVERTISED_10BASET_FULL BIT_ULL(0) > +#define DPNI_ADVERTISED_100BASET_FULL BIT_ULL(1) > +#define DPNI_ADVERTISED_1000BASET_FULL BIT_ULL(2) > +#define DPNI_ADVERTISED_10000BASET_FULL BIT_ULL(4)
So 10 Half and 100Half are not supported by the PHYs you use? What happens if somebody does connect a PHY which supports these speeds? Do you need to change the firmware? I suppose you do anyway, since it is the firmware which is driving the PHY. > struct dpni_link_state { > u32 rate; > u64 options; > + u64 supported; > + u64 advertising; > int up; > + int state_valid; > }; Does the firmware report Pause? Asym Pause? EEE? Is this part of options? Can you control the advertisement of these options? Andrew