The acpi_node_get_property_reference() doesn't return ACPI error codes,
it just returns regular negative kernel error codes.  This patch doesn't
affect run time, it's just a clean up.

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
 drivers/net/phy/sfp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index a991c80e6567..8a99307c1c39 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
                int ret;
 
                ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
-               if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
+               if (ret || !is_acpi_device_node(args.fwnode)) {
                        dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
                        return -ENODEV;
                }
-- 
2.20.1

Reply via email to