From: David Miller <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 14:45:11 -0800 (PST)
> From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Wed, 24 Jan 2007 13:09:40 -0700 > > > > > While enhancing the neighbour code to handle multiple network > > namespaces I noticed that decnet is assuming neigh_parms_alloc > > will allways succeed, which is clearly wrong. So handle the > > failure. > > > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > > I don't think this one is correct. > > During failure cleanup you also have to invoke the neighbour parms > ->down() operation if present, else you leave multicast entries on the > ethernet device for example. BTW, it occurs to me that a good way to handle this might be to try and do the neigh_parms_alloc() before running the ->up() method. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
