On Thu, Jun 06, 2019 at 02:55:19PM +0300, same...@amazon.com wrote:
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 938aca254..7d3837c13 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -2031,6 +2031,20 @@ static int ena_close(struct net_device *netdev)
>       return 0;
>  }
>  
> +int ena_update_queue_sizes(struct ena_adapter *adapter,
> +                        int new_tx_size,
> +                        int new_rx_size)
> +{
> +     bool dev_up;
> +
> +     dev_up = test_bit(ENA_FLAG_DEV_UP, &adapter->flags);
> +     ena_close(adapter->netdev);
> +     adapter->requested_tx_ring_size = new_tx_size;
> +     adapter->requested_rx_ring_size = new_rx_size;
> +     ena_init_io_rings(adapter);
> +     return dev_up ? ena_up(adapter) : 0;
> +}

This function is called with u32 values as arguments by its only caller
and copies them into u32 members of struct ena_adapter. Why are its
arguments new_tx_size and new_rx_size declared as int?

Michal Kubecek

Reply via email to