On Thu, Jun 06, 2019 at 08:05:31AM +0200, Heiner Kallweit wrote:
> On 06.06.2019 03:42, David Miller wrote:
> > From: Robert Hancock <hanc...@sedsystems.ca>
> > Date: Tue, 4 Jun 2019 16:15:01 -0600
> >
> >> Add 1000BaseX to the link modes which are detected based on the
> >> MII_ESTATUS register as per 802.3 Clause 22. This allows PHYs which
> >> support 1000BaseX to work properly with drivers using phylink.
> >>
> >> Previously 1000BaseX support was not detected, and if that was the only
> >> mode the PHY indicated support for, phylink would refuse to attach it
> >> due to the list of supported modes being empty.
> >>
> >> Signed-off-by: Robert Hancock <hanc...@sedsystems.ca>
> >
> > Andrew/Florian/Heiner, is there a reason we left out the handling of these
> > ESTATUS bits?
> >
> >
> I can only guess here:
> In the beginning phylib took care of BaseT modes only. Once drivers for
> BaseX modes were added the authors dealt with it in the drivers directly
> instead of extending the core.
That seems like a reasonable guess. Also, SFPs are also reasonably new
in this field, so using a PHY as a media converter like this was not
needed before.
Andrew
