> -----Original Message----- > From: David Miller <da...@davemloft.net> > Sent: Thursday, June 6, 2019 4:46 AM > To: Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com> > Cc: netdev@vger.kernel.org; Ioana Ciornei <ioana.cior...@nxp.com> > Subject: Re: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes > on Tx > > From: Ioana Radulescu <ruxandra.radule...@nxp.com> > Date: Wed, 5 Jun 2019 12:57:25 +0300 > > > + queue_mapping %= dpaa2_eth_queue_count(priv); > > You are now performing a very expensive modulus operation every single TX > packet, regardless of whether TC is in use or not. > > The whole reason we store the queue mapping pre-cooked in the SKB is so > that you don't have to do this.
Good point, thanks. Will refactor and send a v2. Ioana
