On 2019-06-04 4:18 p.m., Andrew Lunn wrote: >> - axienet_iow(lp, XAE_MDIO_MC_OFFSET, >> - (mdio_mcreg & (~XAE_MDIO_MC_MDIOEN_MASK))); >> + mutex_lock(&lp->mii_bus->mdio_lock); >> + axienet_mdio_disable(lp); > > I wonder if it would look better structured if the lock was in > axienet_mdio_disable() and the unlock in axienet_mdio_enable(lp)? > > As you said, you are trying to refactor all the MDIO code it mdio.c.
Acquiring a lock and not releasing it in a disable() method would seem a little bit evil.. not sure if there is another way to handle that better. The code in _mdio.c doesn't do anything with the mdio_lock so it's not going to conflict between the code in the two files at least. -- Robert Hancock Senior Software Developer SED Systems, a division of Calian Ltd. Email: hanc...@sedsystems.ca
