Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to_ppb

[Richard Cochran]

On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote:
> From: Shalom Toledo <shal...@mellanox.com>
> 
> Publish scaled_ppm_to_ppb to allow drivers to use it.

But why?

> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(struct 
> timestamp_event_queue *queue,
>       spin_unlock_irqrestore(&queue->lock, flags);
>  }
>  
> -static s32 scaled_ppm_to_ppb(long ppm)
> +s32 ptp_clock_scaled_ppm_to_ppb(long ppm)

Six words is a little bit much for the name of a function.

Thanks,
Richard