From: Tom Herbert <t...@herbertland.com>
Date: Tue, 28 May 2019 16:32:42 -0700

> @@ -156,8 +159,11 @@ static bool ip6_parse_tlv(const struct tlvtype_proc 
> *procs,
>                        * See also RFC 4942, Section 2.1.9.5.
>                        */
>                       padlen += optlen;
> -                     if (padlen > 7)
> +                     if (padlen > 7) {
> +                             icmpv6_send(skb, ICMPV6_PARAMPROB,
> +                                         ICMPV6_TOOBIG_OPTION, off);
>                               goto bad;
> +                     }

So much inconsistency.  You're sending the parameter problem here
but you're not for the following code that verifies that the padding
contains only zeros.

Either emit the parameter problem for all bad TLV padding or for none.

Reply via email to