On Fri, May 31, 2019 at 10:26 AM Davide Caratti <dcara...@redhat.com> wrote: > > 'act_csum' was recently fixed to mangle the IPv4/IPv6 header if a packet > having one or more VLAN headers was processed: patch #1 ensures that all > VLAN headers are in the linear area of the skb. > Other actions might read or mangle the IPv4/IPv6 header: patch #2 and #3 > fix 'act_pedit' and 'act_skbedit' respectively.
Maybe, just maybe, vlan tags are supposed to be handled by act_vlan? Which means maybe users have to pipe act_vlan to these actions. >From the code reuse perspective, you are adding TCA_VLAN_ACT_POP to each of them. Thanks.