> -----Original Message-----
> From: Sebastian Andrzej Siewior <bige...@linutronix.de>
> Sent: Thursday, May 30, 2019 1:15 AM
> To: netdev@vger.kernel.org
> Cc: t...@linutronix.de; David S. Miller <da...@davemloft.net>; Sebastian
> Andrzej Siewior <bige...@linutronix.de>; Ioana Ciocoi Radulescu
> <ruxandra.radule...@nxp.com>
> Subject: [PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from
> seed_pool()
>
> According to the comment, the preempt_disable() statement is required
> due to synchronisation in napi_alloc_frag(). The awful truth is that
> local_bh_disable() is required because otherwise the NAPI poll callback
> can be invoked while the open function setup buffers. This isn't
> unlikely since the dpaa2 provides multiple devices.
>
> The usage of napi_alloc_frag() has been removed in commit
>
> 27c874867c4e9 ("dpaa2-eth: Use a single page per Rx buffer")
>
> which means that the comment is not accurate and the preempt_disable()
> statement is not required.
>
> Remove the outdated comment and the no longer required
> preempt_disable().
>
> Cc: Ioana Radulescu <ruxandra.radule...@nxp.com>
> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
Acked-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Thanks,
Ioana
