> -----Original Message----- > From: Sebastian Andrzej Siewior <[email protected]> > Sent: Thursday, May 30, 2019 1:15 AM > To: [email protected] > Cc: [email protected]; David S. Miller <[email protected]>; Sebastian > Andrzej Siewior <[email protected]>; Ioana Ciocoi Radulescu > <[email protected]> > Subject: [PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from > seed_pool() > > According to the comment, the preempt_disable() statement is required > due to synchronisation in napi_alloc_frag(). The awful truth is that > local_bh_disable() is required because otherwise the NAPI poll callback > can be invoked while the open function setup buffers. This isn't > unlikely since the dpaa2 provides multiple devices. > > The usage of napi_alloc_frag() has been removed in commit > > 27c874867c4e9 ("dpaa2-eth: Use a single page per Rx buffer") > > which means that the comment is not accurate and the preempt_disable() > statement is not required. > > Remove the outdated comment and the no longer required > preempt_disable(). > > Cc: Ioana Radulescu <[email protected]> > Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Acked-by: Ioana Radulescu <[email protected]> Thanks, Ioana
