> @@ -423,18 +434,41 @@ static int dsa_tree_setup_switches(struct > dsa_switch_tree *dst) > > err = dsa_switch_setup(ds); > if (err) > - return err; > + goto setup_switch_err;
Minor nit pick. All the other labels you add are err_*. This one is *_err. A quick look at dsa2.c, there is one label already in the file out_put_node: which has no prefix or postfix. So maybe drop err_ and _err ? Andrew
