> phydev = dsa_port_get_phy_device(dp); > if (!phydev) > return 0; > > I don't see how this method is sane either.
If i remember correctly, the thinking was, you can get away without the PHY, at least during bring up of a new switch/board. So don't consider this a fatal error. Now that it is fatal, in the sense of an Opps, maybe we should change this. Andrew