On Mon, May 27, 2019 at 10:17:50PM -0700, Richard Cochran wrote:
> On Wed, May 22, 2019 at 02:58:23AM +0200, Andrew Lunn wrote:
> > > -static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr)
> > > +static int dp83640_hwtstamp(struct mii_timestamper *mii_ts, struct ifreq
> > > *ifr)
> > > {
> > > - struct dp83640_private *dp83640 = phydev->priv;
> > > + struct dp83640_private *dp83640 =
> > > + container_of(mii_ts, struct dp83640_private, mii_ts);
> > > struct hwtstamp_config cfg;
> > > u16 txcfg0, rxcfg0;
> >
> > Hi Richard
> >
> > David might complain about reverse christmas tree. Maybe define a
> > macro, to_dp83640() which takes mii_ts?
>
> That is nice idea for another series, I think. For now this matches
> the existing 'container_of' usage within the driver.
Well, David might reject it because it is not reverse christmas tree.
Andrew
