Hi Vishal, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vishal-Kulkarni/cxgb4-Enable-hash-filter-with-offload/20190521-171528 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:6216:14: sparse: sparse: symbol >> 't4_get_tp_e2c_map' was not declared. Should it be static? drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3838:9: sparse: sparse: context imbalance in 't4_load_phy_fw' - different lock contexts for basic block Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
