On 15.05.2019 20:44, Andrew Lunn wrote:
> On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote:
>> On 15.05.2019 18:19, Florian Fainelli wrote:
>>> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
>>>> XGMII interface mode no longer works on AQR107 after the recent changes,
>>>> adding back support.
>>>>
>>>> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface
>>>> modes in config_init")
>>>>
>>>> Signed-off-by: Madalin Bucur <madalin.bu...@nxp.com>
>>>
>>> Just so you know for future submissions, there is no need for a newline
>>> between your Fixes: and Signed-off-by: tag, it's just a normal tag.
>>>
>>> Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
>>>
>> I checked the datasheet and AQR107 doesn't support XGMII. It supports
>> USXGMII,
>> maybe XGMII is used as workaround because phy_interface_t doesn't cover
>> USXGMII yet. If it makes the board work again, I think using XGMII is fine
>> for
>> now. But we should add USXGMII and the remove this workaround.
>
> Hi Heiner
>
> We should add USXGMII anyway. But that is net-next material, if it is
> not the fix we go with.
>
Right. It's a very small patch, I added it to my tree already.
> Andrew
>
Heiner
